Allow for more dynamic memchr versions, as they follow semver#8
Open
emily-pa wants to merge 2 commits intoheim-rs:masterfrom
Open
Allow for more dynamic memchr versions, as they follow semver#8emily-pa wants to merge 2 commits intoheim-rs:masterfrom
emily-pa wants to merge 2 commits intoheim-rs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This occurred to me after having to nitpick and downgrade various packages in my projects(in some cases to find specific revisions which weren't even tagged) simply in order to get this crate(which is really great, mind you^) to play nice with other crates.
This can be easily resolved by broadening the crate versions used by this project.
libc is guarenteed to not break compat at least for a minor version, and memchr will support semver up to a major version.